Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #106

Merged
merged 4 commits into from
Dec 19, 2022
Merged

Conversation

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 7bcb3ef to 629af0c Compare November 21, 2022 21:50
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 101ab6a to 8e82337 Compare December 5, 2022 22:21
@ast0815
Copy link
Collaborator

ast0815 commented Dec 7, 2022

@henryiii, it looks like MyPy and Flake have different opinions about whether I should from typing import Any, Dict, List, Tuple in cli.py. Do you know how to make them agree on this?

@henryiii
Copy link
Member

henryiii commented Dec 8, 2022

You should convert type comments into type annotations. Flake8 has likely dropped support for type annotations, they were a Python < 3.6 compatibility feature that's not useful anymore. Some tools (like shed with a flag) can auto-convert them for you.

updates:
- [github.com/psf/black: 22.10.0 → 22.12.0](psf/black@22.10.0...22.12.0)
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0)
- [github.com/PyCQA/isort: 5.10.1 → 5.11.1](PyCQA/isort@5.10.1...5.11.1)
- [github.com/asottile/setup-cfg-fmt: v2.1.0 → v2.2.0](asottile/setup-cfg-fmt@v2.1.0...v2.2.0)
- [github.com/asottile/pyupgrade: v3.1.0 → v3.3.1](asottile/pyupgrade@v3.1.0...v3.3.1)
- [github.com/pycqa/flake8: 5.0.4 → 6.0.0](PyCQA/flake8@5.0.4...6.0.0)
- [github.com/pre-commit/mirrors-mypy: v0.982 → v0.991](pre-commit/mirrors-mypy@v0.982...v0.991)
- [github.com/mgedmin/check-manifest: 0.48 → 0.49](mgedmin/check-manifest@0.48...0.49)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 81c87a9 to 49a438f Compare December 12, 2022 23:07
@ast0815 ast0815 force-pushed the pre-commit-ci-update-config branch from 41a221b to cf86b65 Compare December 19, 2022 12:45
@ast0815 ast0815 merged commit 1243308 into master Dec 19, 2022
@ast0815 ast0815 deleted the pre-commit-ci-update-config branch December 19, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants