From e79dc53a20f8bd6f530e0b4afc04d5cf36d4dbcd Mon Sep 17 00:00:00 2001
From: Jakob Vogel <jvo@scireum.de>
Date: Mon, 29 Jul 2024 13:19:43 +0200
Subject: [PATCH] =?UTF-8?q?Uses=20HTML-style=20links=20=F0=9F=94=97?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The `name` attribute has been deprecated earlier in commit a5f4a410156dc2078c474f7aafdc83b6c2e43cd6, thus leading to unwanted warnings when running `eod synchronize-knowledgebase`.

OX-11128
---
 src/main/resources/default/kb/00000.html.pasta         |  3 +--
 .../resources/default/kb/en/user/noodle.html.pasta     |  2 +-
 .../default/kb/en/user/tagliatelle.html.pasta          |  2 +-
 src/main/resources/default/taglib/k/base.html.pasta    | 10 ++++++----
 src/main/resources/default/taglib/k/chapter.html.pasta |  6 ++----
 .../default/templates/biz/tycho/kb/welcome.html.pasta  |  2 +-
 .../templates/biz/tycho/kb/welcome_de.html.pasta       |  2 +-
 7 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/src/main/resources/default/kb/00000.html.pasta b/src/main/resources/default/kb/00000.html.pasta
index d28e7370d..2bb9f2472 100644
--- a/src/main/resources/default/kb/00000.html.pasta
+++ b/src/main/resources/default/kb/00000.html.pasta
@@ -27,8 +27,7 @@
                         <div class="pb-2">
                             <div>
                                 <k:link link="@apply('/kba/%s/%s', chapter.getLanguage(), chapter.getArticleId())"
-                                        icon="fa-solid fa-book"
-                                        name="@chapter.getTitle()"/>
+                                        icon="fa-solid fa-book">@chapter.getTitle()</k:link>
                             </div>
                             <div class="text-muted">
                                 @chapter.getDescription()
diff --git a/src/main/resources/default/kb/en/user/noodle.html.pasta b/src/main/resources/default/kb/en/user/noodle.html.pasta
index 55e301d72..a14ebff91 100644
--- a/src/main/resources/default/kb/en/user/noodle.html.pasta
+++ b/src/main/resources/default/kb/en/user/noodle.html.pasta
@@ -35,7 +35,7 @@
             </li>
             <li>
                 Macro calls: <k:inlineCode>isEmpty("test")</k:inlineCode>. All available macros are listed here:
-                <k:link link="/system/tags" name="Tagliatelle Tag Overview" target="_blank"/>.
+                <k:link link="/system/tags" target="_blank">Tagliatelle Tag Overview</k:link>
             </li>
             <li>
                 If statements: <k:inlineCode>if (condition) { statements; }</k:inlineCode>
diff --git a/src/main/resources/default/kb/en/user/tagliatelle.html.pasta b/src/main/resources/default/kb/en/user/tagliatelle.html.pasta
index da4e7449c..d30cee5d1 100644
--- a/src/main/resources/default/kb/en/user/tagliatelle.html.pasta
+++ b/src/main/resources/default/kb/en/user/tagliatelle.html.pasta
@@ -48,6 +48,6 @@
     </k:section>
     <k:section heading="Available tags and macros" anchor="available-tags-and-macros">
         A list of all available tags and macros can be found here:
-        <k:link link="/system/tags" name="Tagliatelle Tag Overview" target="_blank"/>.
+        <k:link link="/system/tags" target="_blank">Tagliatelle Tag Overview</k:link>
     </k:section>
 </k:article>
diff --git a/src/main/resources/default/taglib/k/base.html.pasta b/src/main/resources/default/taglib/k/base.html.pasta
index 3a60caf19..e77b79fcc 100644
--- a/src/main/resources/default/taglib/k/base.html.pasta
+++ b/src/main/resources/default/taglib/k/base.html.pasta
@@ -61,8 +61,9 @@
                     <i:if test="parent != null">
                         <t:inlineInfo>
                             <k:link link="@apply('/kba/%s/%s', parent.getLanguage(), parent.getArticleId())"
-                                    icon="fa-solid fa-book"
-                                    name="@parent.getTitle()"/>
+                                    icon="fa-solid fa-book">
+                                @parent.getTitle()
+                            </k:link>
                         </t:inlineInfo>
                     </i:if>
                     <t:inlineInfo>
@@ -132,8 +133,9 @@
                                 <div class="pb-2">
                                     <div>
                                         <k:link link="@apply('/kba/%s/%s', reference.getLanguage(), reference.getArticleId())"
-                                                icon="@(reference.isChapter() ? 'fa-solid fa-book' : 'fa-solid fa-file-alt')"
-                                                name="@reference.getTitle()"/>
+                                                icon="@(reference.isChapter() ? 'fa-solid fa-book' : 'fa-solid fa-file-alt')">
+                                            @reference.getTitle()
+                                        </k:link>
                                     </div>
                                     <div class="text-muted">
                                         @reference.getDescription()
diff --git a/src/main/resources/default/taglib/k/chapter.html.pasta b/src/main/resources/default/taglib/k/chapter.html.pasta
index 8bbfc56fe..5c62394b2 100644
--- a/src/main/resources/default/taglib/k/chapter.html.pasta
+++ b/src/main/resources/default/taglib/k/chapter.html.pasta
@@ -38,8 +38,7 @@
                 <div class="pb-2">
                     <div>
                         <k:link link="@apply('/kba/%s/%s', chapter.getLanguage(), chapter.getArticleId())"
-                                icon="fa-solid fa-book"
-                                name="@chapter.getTitle()"/>
+                                icon="fa-solid fa-book">@chapter.getTitle()</k:link>
                     </div>
                     <div class="text-muted">
                         @chapter.getDescription()
@@ -56,8 +55,7 @@
                 <div class="pb-2">
                     <div>
                         <k:link link="@apply('/kba/%s/%s', child.getLanguage(), child.getArticleId())"
-                                icon="fa-solid fa-file-alt"
-                                name="@child.getTitle()"/>
+                                icon="fa-solid fa-file-alt">@child.getTitle()</k:link>
                     </div>
                     <div class="text-muted">
                         @child.getDescription()
diff --git a/src/main/resources/default/templates/biz/tycho/kb/welcome.html.pasta b/src/main/resources/default/templates/biz/tycho/kb/welcome.html.pasta
index 97e7822ba..6a20d047b 100644
--- a/src/main/resources/default/templates/biz/tycho/kb/welcome.html.pasta
+++ b/src/main/resources/default/templates/biz/tycho/kb/welcome.html.pasta
@@ -15,7 +15,7 @@
     <i:if test="isFrameworkEnabled('tycho.open-search')">
         <t:permission permission="permission-open-search">
             Also note that you can use the
-            <k:link link="/open-search" icon="fa-solid fa-search" name="System-wide Search"/>
+            <k:link link="/open-search" icon="fa-solid fa-search">System-wide Search</k:link>
             to find articles for a given keyword.
         </t:permission>
     </i:if>
diff --git a/src/main/resources/default/templates/biz/tycho/kb/welcome_de.html.pasta b/src/main/resources/default/templates/biz/tycho/kb/welcome_de.html.pasta
index 666778cee..3bcb7e81b 100644
--- a/src/main/resources/default/templates/biz/tycho/kb/welcome_de.html.pasta
+++ b/src/main/resources/default/templates/biz/tycho/kb/welcome_de.html.pasta
@@ -15,7 +15,7 @@
     <i:if test="isFrameworkEnabled('tycho.open-search')">
         <t:permission permission="permission-open-search">
             Bitte beachten Sie, dass Sie auch die
-            <k:link link="/open-search" icon="fa-solid fa-search" name="Systemweite Suche"/>
+            <k:link link="/open-search" icon="fa-solid fa-search">Systemweite Suche</k:link>
             verwenden können, um entsprechende Hilfeseiten zu finden.
         </t:permission>
     </i:if>