Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link in case of private #205

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Fix link in case of private #205

merged 2 commits into from
Jul 15, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Jul 3, 2024

This pull request fixes error in case of private ranch is used.

See sclorg/s2i-nodejs-container#437

Job is here: https://github.com/sclorg/s2i-nodejs-container/actions/runs/9774050635/job/26981493749

At the end is:

     timeout: 480
    tmt_path: .
Notice: Testing Farm logs: http://artifacts.osci.redhat.com/testing-farm/79ec2117-69cb-40f9-b3ee-d9b18740ccdf
Error: "<html>\r\n<head><title>502 Bad Gateway</title></head>\r\n<body>\r\n<center><h1>502 Bad Gateway</h1></center>\r\n<hr><center>nginx/1.20.0</center>\r\n</body>\r\n</html>\r\n"

But the tests are here and passed: https://artifacts.osci.redhat.com/testing-farm/79ec2117-69cb-40f9-b3ee-d9b18740ccdf/

phracek added 2 commits July 3, 2024 15:08
@phracek
Fix link to testing-farm. Use https instead of http
7c6b96e 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Add generated files by 'yarn run all'
525373c 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Jul 3, 2024

[test]

@phracek phracek requested review from jamacku and zmiklank July 3, 2024 13:12
@phracek phracek added type: bug Something isn't working good first issue Good for newcomers ready for review type: bugfix labels Jul 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (a21f980) to head (525373c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files          10       10           
  Lines         689      689           
  Branches       73       73           
=======================================
  Hits          609      609           
  Misses         78       78           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phracek phracek removed the request for review from zmiklank July 15, 2024 08:21
@phracek
Copy link
Member Author

phracek commented Jul 15, 2024

@jamacku PTAL. Thanks.

jamacku
jamacku approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamacku jamacku removed type: bug Something isn't working good first issue Good for newcomers ready for review labels Jul 15, 2024
@jamacku jamacku merged commit 276e2a8 into main Jul 15, 2024
11 checks passed
@jamacku jamacku deleted the fix_link_to_private branch July 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamacku jamacku jamacku approved these changes

Assignees
No one assigned
Labels
type: bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phracek @jamacku