Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import deprecation warning from Python 3.7 #107

Closed
dcecile opened this issue Jan 30, 2019 · 1 comment
Closed

Import deprecation warning from Python 3.7 #107

dcecile opened this issue Jan 30, 2019 · 1 comment

Comments

@dcecile
Copy link

dcecile commented Jan 30, 2019

Running Lupa in Python 3.7, I noticed this deprecation warning:

.../lib/python3.7/site-packages/lupa/__init__.py:18: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

I think it's this import from lupa/_lupa.pyx:

from collections import Mapping

Switching the import to collections.abc won't work for Python 2, so an extra check would be needed... (Six has an open issue)

@scoder scoder closed this as completed in 63f9262 Feb 1, 2019
@scoder
Copy link
Owner

scoder commented Feb 1, 2019

Thanks, fixed in lupa 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants