Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brunch as dependency #13

Open
ilkosta opened this issue Sep 18, 2012 · 2 comments
Open

brunch as dependency #13

ilkosta opened this issue Sep 18, 2012 · 2 comments

Comments

@ilkosta
Copy link
Contributor

ilkosta commented Sep 18, 2012

Why insert brunch as dependency?
I think it is preferable to indicate that brunch must be present (preferably system-wide) and that the user can run npm install normally.

I think that the presence of a init.sh script can alienate novice windows users. It can be replaced by a init.js but I think that this is a false problem.

What do you think about?

@kylefinley
Copy link
Member

I have been thinking a lot about this. The initial reason for the scripts was simply following what had been done in angular-seed. You are correct in that using only bash my alienate Windows user, though. What do you think about using npm? E.g.:

npm init to replace ./scripts/init.sh
npm start to replace ./scripts/server.sh
npm test to replace ./scripts/test.sh

This would keep things consistent and allow us to use the local version i.e. node_modules/brunch/bin/brunch of brunch and testacular.

The only scripts left would be:

./scripts/development.sh and ./scripts/production.sh which are less often used, and could use brunch directly.

And ./scripts/compile-tests.sh which I would like to remove anyways. I'm thinking about switching to mocha + Chai because they allow you to right tests in coffeescript directly.

Do you think that use npm would work?

@ilkosta
Copy link
Contributor Author

ilkosta commented Sep 20, 2012

I can not tell you much about which test system to use because I'm really ignorant about them.
For the others scripts replacement, I think that's a good way to simplify things, although I have not tested that everything will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants