Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapter_11/01_line_chart.html #34

Open
ornenovino opened this issue Sep 25, 2018 · 4 comments
Open

chapter_11/01_line_chart.html #34

ornenovino opened this issue Sep 25, 2018 · 4 comments
Assignees
Labels
v5 This needs revision for D3 v5.x

Comments

@ornenovino
Copy link

Line 36 - in d3 v5 it has changed to:

d3.csv("mauna_loa_co2_monthly_averages.csv", rowConverter).then(function(data) {...} ;

@ornenovino
Copy link
Author

This is for all the scripts where you have to import a file, in all this cases from .csv

@scotthmurray scotthmurray self-assigned this Sep 26, 2018
@scotthmurray scotthmurray added the v5 This needs revision for D3 v5.x label Sep 26, 2018
@scotthmurray
Copy link
Owner

Thanks. This is on hold for now, but I will keep it on file should I ever take on a v5 update. :-)

@ornenovino
Copy link
Author

@scotthmurray
Copy link
Owner

Yes. The CHANGES.md doc here: https://github.com/d3/d3/blob/master/CHANGES.md

…says:

With the adoption of promises, D3 now uses the Fetch API instead of XMLHttpRequest: the d3-request module has been replaced by d3-fetch. Fetch supports many powerful new features, such as streaming responses.

See: https://github.com/d3/d3-fetch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 This needs revision for D3 v5.x
Projects
None yet
Development

No branches or pull requests

2 participants