Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converting rows in d3.csv() #40

Open
VirginiaBalseiro opened this issue Jul 7, 2019 · 2 comments
Open

converting rows in d3.csv() #40

VirginiaBalseiro opened this issue Jul 7, 2019 · 2 comments
Assignees
Labels
next book update To incorporate on the next update to the book v5 This needs revision for D3 v5.x

Comments

@VirginiaBalseiro
Copy link

VirginiaBalseiro commented Jul 7, 2019

I had to change:

d3.csv("time_scale_data.csv", rowConverter, function(data) {...})

to:

d3.csv("time_scale_data.csv", rowConverter).then(function(data) {...})

to get it to work.

@scotthmurray scotthmurray self-assigned this Jul 8, 2019
@scotthmurray scotthmurray added next book update To incorporate on the next update to the book v5 This needs revision for D3 v5.x labels Jul 8, 2019
@scotthmurray
Copy link
Owner

Thanks for reporting! Yes, this is one of many things that changed with D3 v5.0. (The 2nd edition of the book addresses v4.5.0 only.)

I will leave this issue open for some future update to the book. :)

@seanlacey
Copy link

Thank you Virginia! Was hitting my head against the wall on this one. Wish I had looked at the issue log first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next book update To incorporate on the next update to the book v5 This needs revision for D3 v5.x
Projects
None yet
Development

No branches or pull requests

3 participants