Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nip05: content length missing or exceeded limits for account #147

Open
aidik opened this issue Jul 27, 2023 · 2 comments
Open

nip05: content length missing or exceeded limits for account #147

aidik opened this issue Jul 27, 2023 · 2 comments

Comments

@aidik
Copy link
Contributor

aidik commented Jul 27, 2023

When going through the logs of my 0.8.8 version nostr-rs-relay I noticed that there are some strange NIP-05 messages:

Jul 27 07:45:46 nostrbox nostr-rs-relay[19526]: Jul 27 07:45:46.356  INFO nostr_rs_relay::nip05: got metadata event for ("BigDave@webtr.io","6bc58cf5")
Jul 27 07:45:46 nostrbox nostr-rs-relay[19526]: Jul 27 07:45:46.743  INFO nostr_rs_relay::nip05: content length missing or exceeded limits for account: "BigDave@webtr.io"
Jul 27 07:45:46 nostrbox nostr-rs-relay[19526]: Jul 27 07:45:46.743  INFO nostr_rs_relay::nip05: checked name "BigDave@webtr.io", result: Unknown, in: 386.092198ms

I then tried manually sending Dave's metadata (kind 0) using the WS extension in Chrome and got the same results in the logs.

Here is the payload I sent:

["EVENT",{"content":"{\"name\":\"BigDave\",\"username\":\"BigDave\",\"display_name\":\"Big Dave\",\"displayName\":\"Big Dave\",\"picture\":\"https://cdn.nostr.build/i/fbe305da7c09fc1c8b6a598da01b3ea0a4b4b98b4cdc0eaa4a5a324aa10ab04e.jpg\",\"banner\":\"https://pbs.twimg.com/profile_banners/1458866524043808782/1687524031/1080x360\",\"website\":\"\",\"about\":\"Irish guy ☘️ who loves Memes , gaming and money. \\nUncensored and free 👍☘️\",\"nip05\":\"BigDave@webtr.io\",\"lud16\":\"lnurl1dp68gurn8ghj7ampd3kx2ar0veekzar0wd5xjtnrdakj7tnhv4kxctttdehhwm30d3h82unvwqhhgun9dej8jumsv95kuv3h8g50nh\",\"lud06\":\"\"}","created_at":1690235259,"id":"a03ed677abe0564c0873918c76a1a70e2b7c2743be1954f9ff4bb3542ffe44c7","kind":0,"pubkey":"6bc58cf504fdfe8ab6ae4f0bd0ae5cf2b0ad859519ad9bc9691cb4a04d46cebf","sig":"83e9779e6d4f6f7cf243acb3a9d0309463ac72d5b90f99e08729da8fa181ffe1396bf6a9cc63073b1e6d1c28e3980826e3155ab4dc5116db8f397b0e5ca9dfde","tags":[]}]

It is not longer than the 64 KB currently set in config.toml.
When I checked https://webtr.io/.well-known/nostr.json?name=BigDave I got back:

{
    "names": {
        "BigDave": "6bc58cf504fdfe8ab6ae4f0bd0ae5cf2b0ad859519ad9bc9691cb4a04d46cebf"
    }
}

So I believe he should have been correctly verified.

This issue might be connected with #130

@scsibug
Copy link
Owner

scsibug commented Jul 29, 2023

Yep, something going on here, thanks for the test case. Need to dig in and figure why this doesn't work...

@scsibug
Copy link
Owner

scsibug commented Sep 4, 2023

Most likely scenario is that the server isn't providing a content-length, and I prevented the NIP-05 verifier from pulling arbitrarily large files (since those get buffered straight into memory, and could cause memory exhaustion of the relay).

I'm not even sure the content-length is enough, since I have not verified if Hyper verifies the length.

We probably need to use something like Limited (https://docs.rs/http-body/0.4.5/http_body/struct.Limited.html) to enforce a limit here, but that's just a TODO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants