Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ethtool metrics to datadog integration #2163

Closed
amnonh opened this issue Jan 28, 2024 · 2 comments · Fixed by #2165
Closed

Add ethtool metrics to datadog integration #2163

amnonh opened this issue Jan 28, 2024 · 2 comments · Fixed by #2165
Labels
enhancement New feature or request

Comments

@amnonh
Copy link
Collaborator

amnonh commented Jan 28, 2024

The following potential metrics should be exported to datalog:
HELP node_ethtool_bw_in_allowance_exceeded Network interface bw_in_allowance_exceeded
HELP node_ethtool_bw_out_allowance_exceeded Network interface bw_out_allowance_exceeded
HELP node_ethtool_conntrack_allowance_exceeded Network interface conntrack_allowance_exceeded
HELP node_ethtool_linklocal_allowance_exceeded Network interface linklocal_allowance_exceeded
HELP node_ethtool_pps_allowance_exceeded Network interface pps_allowance_exceeded

@amnonh amnonh added the enhancement New feature or request label Jan 28, 2024
@mykaul
Copy link
Contributor

mykaul commented Jan 28, 2024

Are you sure it is called 'ethtool_...' ? See https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch-Agent-network-performance.html - "When the CloudWatch agent imports these metrics into CloudWatch from Linux instances, it prepends ethtool_ at the beginning of each of these metric names."

@amnonh
Copy link
Collaborator Author

amnonh commented Jan 28, 2024

The above metrics are taken from the node_exporter metrics, this issue is about mark them with a label so that datadog agent would pick them up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants