Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create proposal for ScyllaDBDatacenter/v1alpha1 API #1978

Closed
tnozicka opened this issue Jun 19, 2024 · 0 comments · Fixed by #1994
Closed

Create proposal for ScyllaDBDatacenter/v1alpha1 API #1978

tnozicka opened this issue Jun 19, 2024 · 0 comments · Fixed by #1994
Assignees
@zimnx
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@tnozicka
Copy link
Member

tnozicka commented Jun 19, 2024 •
edited
Loading

Over the years there was several things we could have done better while designing our ScyllaCluster API, some even contradict kubernetes API conventions. Even the API itself truly represents only a single datacenter, not the whole cluster. This bring in some confusion we should fix as well.

Edited:

We should create new API called ScyllaDBDatacenter/v1alpha1 in the same API group (scylla.scylladb.com) that can take over the implementation logic for handling a data center and the old ScyllaCluster/v1 can create this resource on the background as an implementation detail. This means there will a a conversion path for ScyllaCluster/v1 into ScyllaDBDatacenter/v1alpha1.

The new API must comply with https://github.com/kubernetes/community/blob/ecb8918/contributors/devel/sig-architecture/api-conventions.md
@scylla-operator-bot scylla-operator-bot bot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 19, 2024
@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 19, 2024
@scylla-operator-bot scylla-operator-bot bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 19, 2024
@tnozicka tnozicka removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2024
@zimnx zimnx mentioned this issue Jun 26, 2024
Merged
@tnozicka tnozicka mentioned this issue Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zimnx zimnx

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add proposal for new API v1alpha1.ScyllaDBDatacenter zimnx/scylla-operator
2 participants
@zimnx @tnozicka