Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding embedded image references for testing #2071

Closed
tnozicka opened this issue Aug 13, 2024 · 1 comment
Closed

Allow overriding embedded image references for testing #2071

tnozicka opened this issue Aug 13, 2024 · 1 comment
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@tnozicka
Copy link
Member

We should allow overriding the embedded image references to e.g. Grafana or Prometheus for testing purposes. ScyllaOperatorConfig seems like a fitting place.

For production purposes, we need to rely on exactly the same content of the referenced images to be present to avoid incompatibilities breakages so this should only be adjusted for testing purposes. All the fields should be behind unsupported prefix.

Given the components used in the stack can change, all such fields should be optional.

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 13, 2024
@tnozicka tnozicka self-assigned this Aug 13, 2024
@tnozicka
Copy link
Member Author

tnozicka commented Sep 3, 2024

done in #2081

@tnozicka tnozicka closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

1 participant