Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context on which condition failed in WaitForObjectState #2055

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Aug 2, 2024

Description of your changes:
When multiple conditions are used with WaitForObjectState and it times out, it will now print information about which conditions were evaluated and their state.

Which issue is resolved by this Pull Request:
Resolves #2054

@tnozicka tnozicka added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. labels Aug 2, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2024
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign rzetelskik

@tnozicka
Copy link
Member Author

tnozicka commented Aug 6, 2024

#2061 (comment)
/retest

@tnozicka
Copy link
Member Author

tnozicka commented Aug 6, 2024

/test images

@tnozicka
Copy link
Member Author

tnozicka commented Aug 6, 2024

/test e2e-gke-parallel-clusterip

@rzetelskik rzetelskik self-requested a review August 6, 2024 12:01
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left more comments but I don't see much point in delaying this
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit e7c45dc into scylladb:master Aug 6, 2024
12 checks passed
@tnozicka tnozicka deleted the wait-context branch August 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WaitForObjectState doesn't identify which condition has failed
3 participants