Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop GinkgoRecover from ginkgo's container nodes #2100

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Aug 28, 2024

Description of your changes: GinkgoRecover should only be called when we're spawning goroutines from within a run spec. We are currently calling it from almost every container node, which, in case of a failed assertion in a container node (which shouldn't happen either way, see discussion in #2098), results in silencing an error from run spec tree construction: see e.g. onsi/ginkgo#931 (comment). It only doesn't happen now on broken framework initialization because we have two container nodes which don't call GinkgoRecover.
This PR drops the GinkgoRecover calls from the remaining container nodes.

Which issue is resolved by this Pull Request:
Resolves #

/kind bug
/priority important-soon
/cc

Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: GinkgoRecover should only be called when we're spawning goroutines from within a run spec. We are currently calling it from almost every container node, which, in case of a failed assertion in a container node (which shouldn't happen either way, see discussion in #2098), results in silencing an error from run spec tree construction: see e.g. onsi/ginkgo#931 (comment). It only doesn't happen now for broken framework initialization because we have two container nodes which don't call GinkgoRecover.
This PR drops the GinkgoRecover calls from the remaining container nodes.

Which issue is resolved by this Pull Request:
Resolves #

/kind bug
/priority important-soon
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2024
@rzetelskik rzetelskik changed the title [WIP] Drop GinkgoRecover from ginkgo's container nodes Drop GinkgoRecover from ginkgo's container nodes Aug 28, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2024
@rzetelskik
Copy link
Member Author

/cc zimnx tnozicka

Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign tnozicka

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
thanks

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit fe5d18c into scylladb:master Aug 29, 2024
12 checks passed
@rzetelskik rzetelskik deleted the drop-ginkgo-recover branch September 27, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants