-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize ScyllaDB Manager version with config.yaml #2107
Synchronize ScyllaDB Manager version with config.yaml #2107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/assign rzetelskik
well, we can't use the same sha for manager agent and manager images as those are different images (same version but not sha) |
We can, although I think it would be better to have two configuration values with different sha's but the same semantic version for each image. |
8ea0633
to
6b00965
Compare
I've split the agent version, ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
This fixes version synchronization for ScyllaDB Manager deployment with the
config.yaml
.(@rzetelskik found out this is not getting replaced)