Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize ScyllaDB Manager version with config.yaml #2107

Merged

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Sep 3, 2024

Description of your changes:
This fixes version synchronization for ScyllaDB Manager deployment with the config.yaml.

(@rzetelskik found out this is not getting replaced)

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. labels Sep 3, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2024
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign rzetelskik

@tnozicka
Copy link
Member Author

tnozicka commented Sep 3, 2024

well, we can't use the same sha for manager agent and manager images as those are different images (same version but not sha)
message: Back-off pulling image "docker.io/scylladb/scylla-manager-agent:3.3.0@sha256:e8c5b62c9330f91dfca24f109b033df78113d3ffaac306edf6d3c4346e1fa0bf"
@rzetelskik @zimnx can we get rid of the sha with a newer manager version?

@zimnx
Copy link
Collaborator

zimnx commented Sep 3, 2024

can we get rid of the sha with a newer manager version?

We can, although I think it would be better to have two configuration values with different sha's but the same semantic version for each image.

@tnozicka tnozicka force-pushed the fix-manager-version-replacement branch from 8ea0633 to 6b00965 Compare September 3, 2024 14:47
@tnozicka
Copy link
Member Author

tnozicka commented Sep 3, 2024

I've split the agent version, ptal

Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 9e4ed32 into scylladb:master Sep 3, 2024
13 checks passed
@tnozicka tnozicka deleted the fix-manager-version-replacement branch September 3, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants