Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce input/output buffer copies in model processing #27

Closed
mikeoliphant opened this issue Apr 2, 2023 · 1 comment · Fixed by #78
Closed

Reduce input/output buffer copies in model processing #27

mikeoliphant opened this issue Apr 2, 2023 · 1 comment · Fixed by #78
Assignees
Labels
enhancement New feature or request

Comments

@mikeoliphant
Copy link
Contributor

Currently, there are at least two buffer copies (one at input and one at output) that could be avoided by directly using the passed in input/output buffers.

@olilarkin
Copy link
Contributor

olilarkin commented May 6, 2023

I agree. Also, the whole allocating arrays of raw input/output pointers stuff in both NeuralAmpModelerCore and the Plug-in code is very suspicious and possibly the source of some of the memory leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants