Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to allow-list for WAVE file chunks #38

Closed
sdatkinson opened this issue Apr 25, 2023 · 0 comments · Fixed by #39
Closed

Switch to allow-list for WAVE file chunks #38

sdatkinson opened this issue Apr 25, 2023 · 0 comments · Fixed by #39
Labels
enhancement New feature or request

Comments

@sdatkinson
Copy link
Owner

The skip-list is getting long. An allow-list (i.e. idIsNotJunk()) will probably be a simpler implementation and support more formats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read WAV files via allow-list of chunks sdatkinson/NeuralAmpModelerCore
1 participant
@sdatkinson