New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Eigen::Ref<> ? #73

Open

olilarkin opened this issue Sep 15, 2023 · 0 comments

Contributor

olilarkin commented Sep 15, 2023

I haven't properly checked if this is the case here, but using Eigen types as function parameters can result in unwanted temporary copies in some cases. The Eigen::Ref<> class exists to work around this. Further information here: http://eigen.tuxfamily.org/dox/TopicFunctionTakingEigenTypes.html#TopicUsingRefClass

I wondered if this might be one lever for optimizing the NAMCore code

https://github.com/sdatkinson/NeuralAmpModelerCore/blob/885a535d29022138f3efcbfd73aed4743f750b68/NAM/wavenet.h#L102C6-L102C6

sdatkinson mentioned this issue

Remove parametric model code #81

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment