Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

Add tests to ensure semver leading 'v' doesn't mess us up #135

Open
sdboyer opened this issue Jan 5, 2017 · 2 comments
Open

Add tests to ensure semver leading 'v' doesn't mess us up #135

sdboyer opened this issue Jan 5, 2017 · 2 comments

Comments

@sdboyer
Copy link
Owner

sdboyer commented Jan 5, 2017

When a constraint is specified with a leading v, but the underlying version lacks it, or vice versa, it's correct to elide that difference and have both cases match.

I don't think we do this now, but I'm honesty not sure. Need some tests to check.

@sdboyer
Copy link
Owner Author

sdboyer commented Jan 5, 2017

At least half of the importance here is just clearly identifying where in the solving algorithm the decision gets made about what form we actually use. I'm pretty sure it takes from the vcs when populating the solution, so we should always be good as long as the constraint Match()es the version, but being really clear about this would be a plus.

@fabulous-gopher
Copy link

This issue was moved to golang/dep#430

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants