Parser: Allow connection line to be specified multiple times #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemosupremo
force-pushed
the
fix/allow-multiple-connection
branch
from
b88412e to
3fd6af1
Compare
nemosupremo
force-pushed
the
fix/allow-multiple-connection
branch
from
3fd6af1 to
d9add17
Compare
|
That makes sense, and I think we should do the same for all the other cases like this (no need to do this as part of this PR). It would probably also make sense to add a dependency on the |
|
The clippy warning should be gone now if you rebase |
|
@nemosupremo Any updates here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've misplaced the wireshark output, but we ran into a situation where a camera's rtsp stream we were working with had specified the connection line multiple times; which caused sdp-types to fail parsing. This new just skips the duplicate lines instead. I can understand the rationale of failing on bad input, but I think the robustness principle applies.