Fix a bug that disabling directives are not properly applied in some cases #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node#line_numbers includes line numbers of child nodes. That causes RootNode#node_for_line to return an ancestor of the node containing the specified line. Directives are applied based on RootNode#node_for_line, so there are cases like sds#303 where directives are not properly applied.
|
Thanks @kiyot. This issue seems to be affecting a decent number of folks, so appreciate a push in a direction that alleviates, though I'm not sure about this statement:
I don't have a good sense of whether this is true/false, but I accept that an attempt at a fix is better than no action. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #303
Node#line_numbers includes line numbers of child nodes. That causes RootNode#node_for_line to return an ancestor of the node containing the specified line.
Directives are applied based on RootNode#node_for_line, so there are cases like #303 where directives are not properly applied.
Concerns
This PR reverts some part of #278, which is about multiline node handling.
I believe child nodes are not meant to be handled like multilines, and this PR should be okay.