Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android CI build #1169

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

glyphpoch
Copy link
Contributor

Use "cross" to cross-compile reqwest for Android. The job currently
errors out because the default linker doesn't know what to do with
object files generated for Android.

Use "cross" to cross-compile reqwest for Android. The job currently
errors out because the default linker doesn't know what to do with
object files generated for Android.
Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! I wasn't immediately sure what was wrong, just knew that something blew up

@seanmonstar seanmonstar merged commit ad21b62 into seanmonstar:master Feb 9, 2021
@glyphpoch glyphpoch deleted the fix-android-ci-build branch February 9, 2021 19:04
@glyphpoch
Copy link
Contributor Author

Yeah.. I sadly have no idea what is wrong either. The last successful build was using this image:

and then started breaking when ubuntu:latest started pointing at this one:

There don't seem to be any Android related differences. NDK was updated a while ago but then reverted, probably shouldn't have been affected by that: actions/runner-images#2420

Hopefully cross will make it stay stable, I didn't see any immediate downsides to using it, the build might be a bit slower since it needs to pull a docker image every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants