Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

san-ssr 的 PHP 版本建议添加配置项来确定是否需要输出反解注释 #21

Closed
l5oo00 opened this issue Nov 12, 2019 · 3 comments · Fixed by #23
Closed

san-ssr 的 PHP 版本建议添加配置项来确定是否需要输出反解注释 #21

l5oo00 opened this issue Nov 12, 2019 · 3 comments · Fixed by #23
Labels
enhancement New feature or request released

Comments

@l5oo00
Copy link
Contributor

l5oo00 commented Nov 12, 2019

建议根据 render 函数的 noOutputData 参数来确定， 配置不输出数据的话， 反解相关的注释也都不输出:

  • 序列化的数据
  • 复合插值文本标记
@PengXing
Copy link

补充一个例子

<script type="text/javascript">
  page.comm1 = page.comm1 || {};
  page.comm1.isShowInapp = {{queryInfo.showInapp ? 1 : 0}};
</script>

image

@harttle harttle added the enhancement New feature or request label Nov 13, 2019
@l5oo00 l5oo00 mentioned this issue Nov 13, 2019
Merged
harttle pushed a commit that referenced this issue Nov 13, 2019
@semantic-release-bot
chore(release): 1.3.3 [skip ci]
25a0f20 
## [1.3.3](v1.3.2...v1.3.3) (2019-11-13)

### Bug Fixes

* remove <!--s-text--><!--/s-text--> when noDataOutput is true, fixes [#21](#21) ([4f5132c](4f5132c))
@harttle
Copy link
Member

harttle commented Nov 13, 2019

🎉 This issue has been resolved in version 1.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

harttle pushed a commit that referenced this issue Nov 14, 2019
@l5oo00 @harttle
fix: remove <!--s-text--><!--/s-text--> when noDataOutput is true, fixes
c05ef7d 
 #21
harttle pushed a commit that referenced this issue Nov 14, 2019
@semantic-release-bot @harttle
chore(release): 1.3.3 [skip ci]
0414c3c 
## [1.3.3](v1.3.2...v1.3.3) (2019-11-13)

### Bug Fixes

* remove <!--s-text--><!--/s-text--> when noDataOutput is true, fixes [#21](#21) ([4f5132c](4f5132c))
harttle pushed a commit that referenced this issue Nov 14, 2019
@semantic-release-bot
chore(release): 1.3.4 [skip ci]
4876d56 
## [1.3.4](v1.3.3...v1.3.4) (2019-11-14)

### Bug Fixes

* format compilerOptions for ts2php, fixes [#19](#19) ([cb2329d](cb2329d))
* remove <!--s-text--><!--/s-text--> when noDataOutput is true, fixes [#21](#21) ([c05ef7d](c05ef7d))
@harttle
Copy link
Member

harttle commented Nov 14, 2019

🎉 This issue has been resolved in version 1.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove <!--s-text--><!--/s-text--> when noDataOutput is true
3 participants
@PengXing @l5oo00 @harttle