Test with -Z minimal-versions on CI
#114
Conversation
.travis.yml
Outdated
| @@ -10,6 +10,9 @@ before_script: | |||
| script: | |||
| - cargo run -p ci | |||
| - cargo run --example default | |||
| - if [ "${TRAVIS_RUST_VERSION}" = nightly ]; then cargo update -Z minimal-versions; fi | |||
There was a problem hiding this comment.
Could we run this as a separate travis environment that just does the -Z minimal-versions check at the start?
There was a problem hiding this comment.
A separate travis job is fine, but what do you mean by "just the -Z minimal-versions check at the start"? Just cargo update -Z minimal-versions is not enough.
There was a problem hiding this comment.
Ah I meant switch on some environment variable instead of the nightly version. But the script is only a few lines so we could just duplicate the script in the travis environment specifically for testing minimal versions.
There was a problem hiding this comment.
Gotcha, I'll try the switch one then.
|
When I pushed the last commit, some errors were happening on GitHub, so Travis built the first commit instead. Is there a way to re-trigger the build with the correct commit? |
|
Oh wierd! I've retriggered the build, if this one looks good then I'll go ahead and merge. |
|
Hmm, looks like it's still running the previous commit... I'll just go ahead and merge and tweak it if it needs it. Thanks @hcpl! |
Probably a GitHub database migration/de-synchronization issue (source: https://twitter.com/castillojorgey/status/1060054801000685568). The merge build contains the last commit, so all good now. Thanks for merging! |
Just to make sure that reverse dependencies on
env_loggerwon't break on-Z minimal-versionsas well.