Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more timestamp precisions #140

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Conversation

oherrala
Copy link
Contributor

@oherrala oherrala commented Sep 9, 2019

This PR adds two more timestamp precisions: milliseconds and microseconds.

I sprinkled some #[deprecated] tags around for things I consider could be removed in the future since the same functionality can be achieved in other way.

This probably still have sharp corners to work on.

Fixes #122

Copy link
Collaborator

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up @oherrala!

This looks good to me. Would you like to rebase on master now that we've bumped our minimum version?

@oherrala
Copy link
Contributor Author

@KodrAus Rebase done. Travis seems happy.

@KodrAus KodrAus merged commit 75911d7 into rust-cli:master Sep 13, 2019
@oherrala oherrala deleted the timestamp-formats branch September 13, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timestamps with milliseconds
2 participants