Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted in #72
The
pub use termcolor::Color
we releasedenv_logger 0.5.0
with was a bad call.This PR duplicates the
termcolor::Color
API inenv_logger
so breaking changes intermcolor
can be managed with some gymnastics inenv_logger
.If a new variant is added to
termcolor::Color
:Color::from_termcolor
will returnNone
until/unless we have a corresponding variantColor::FromStr
will returnErr::Unrecognized
until/unless we have a corresponding variantIf
termcolor
drops the concept ofColor
completely then we have a little more work to do, but it should still all be manageable.This will technically be a breaking change, since our
ParseColorError
isn't equivalent totermcolor::ParseColorError
so you couldn't?
it andColor
isn't equivalent totermcolor::Color
, but pragmatically I think this is safe to make in a patch.cc @BurntSushi @briansmith what do you think?