there doesn't seem to be a way for reflection to fail here, so removi…

…ng try catch
sebastianbergmann · Jul 7, 2018 · 3f8c69c · 3f8c69c
1 parent 7e68764
commit 3f8c69c
Showing 1 changed file with 9 additions and 14 deletions.
diff --git a/src/Framework/TestResult.php b/src/Framework/TestResult.php
@@ -814,24 +814,19 @@ public function run(Test $test): void
         } elseif ($this->beStrictAboutTestsThatDoNotTestAnything &&
             !$test->doesNotPerformAssertions() &&
             $test->getNumAssertions() == 0) {
-            try {
-                $reflected = new \ReflectionClass($test);
-                $name      = $test->getName(false);
+            $reflected = new \ReflectionClass($test);
+            $name      = $test->getName(false);
 
-                if ($name && $reflected->hasMethod($name)) {
-                    $reflected = $reflected->getMethod($name);
-                }
-                $message = \sprintf(
-                    "This test did not perform any assertions\n\n%s:%d",
-                    $reflected->getFileName(),
-                    $reflected->getStartLine()
-                );
-            } catch (\ReflectionException $exception) {
-                $message = 'This test did not perform any assertions';
+            if ($name && $reflected->hasMethod($name)) {
+                $reflected = $reflected->getMethod($name);
             }
             $this->addFailure(
                 $test,
-                new RiskyTestError($message),
+                new RiskyTestError(\sprintf(
+                    "This test did not perform any assertions\n\n%s:%d",
+                    $reflected->getFileName(),
+                    $reflected->getStartLine()
+                )),
                 $time
             );
         } elseif ($this->beStrictAboutTestsThatDoNotTestAnything &&