Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm-storage): Fix failing test regarding validation #61

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

JeancarloBarrios
Copy link
Contributor

This PR is just a quick fi to fix falling test, in order to get the testing tooling pr passing

@JeancarloBarrios JeancarloBarrios marked this pull request as ready for review September 29, 2023 12:55
Copy link
Member

@hacheigriega hacheigriega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think you can remove changes in msg_server_test.go because #60 addresses them and a few more issues?

@hacheigriega
Copy link
Member

But can you please change the Wasm file name from simple-dr.wasm to oversized.wasm in msg_server_test.go? That didn't get added to my git commit 🤦‍♂️

@JeancarloBarrios
Copy link
Contributor Author

sm file name from simple-dr.wasm to oversized.wasm in msg_server_test.go? That didn't get added to my git commit 🤦‍♂️

sure!!!!

Copy link
Member

@mariocao mariocao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind rewording the commit 9eb4b5f40cd7eb3d8cedad90186adc36964a95f9 with the message "Merge branch 'main' into JeancarloBarrios/fixing-wasm-validation-test" to be compliant with conventional commits? :)

@JeancarloBarrios
Copy link
Contributor Author

rding the commit 9eb4b5f with the message "Merge branch 'main' into JeancarloBarrios/fixing-wasm-validation-test" to be compliant with conventional commits? :)

yes I will rebase it back to a single commit and remove it

@JeancarloBarrios JeancarloBarrios force-pushed the JeancarloBarrios/fixing-wasm-validation-test branch from 1652d6a to 384457f Compare September 29, 2023 17:11
@JeancarloBarrios JeancarloBarrios merged commit 384457f into main Sep 29, 2023
@JeancarloBarrios JeancarloBarrios deleted the JeancarloBarrios/fixing-wasm-validation-test branch September 29, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants