Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

fix(deps): Update html-sketchapp to v3.x #38

Merged
merged 4 commits into from
May 14, 2018

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 23, 2018

This Pull Request updates dependency @​brainly/html-sketchapp from ^2.0.0 to ^3.0.0

Release Notes

v3.1.0

Compare Source

New

  • ability to set resizing constraints by @​ryanseddon
layer.setResizingConstraint(RESIZING_CONSTRAINTS.LEFT, RESIZING_CONSTRAINTS.TOP);
screen shot 2018-04-26 at 13 44 44 #### Fix
  • avoid empty groups by not traversing SVG nodes in nodeTreeToSketchGroup by @​TheReincarnator
  • clean up tests by @​kdzwinel

v3.0.2

Compare Source

  • Artboard no longer fails if options object is not provided
  • Plugin now better supports nested structures (e.g. created by nodeTreeToSketchPage) - import doesn't fail if one of the layers fail.
  • zoomToFit no longer fails if there is nothing to zoom to

v3.0.1

Compare Source
Somehow npm package was published w/o package.json and README.md. I have no idea how this is even possible 😵


v3.0.0

Compare Source
This release is 90% handmade by @​TheReincarnator 👏Thank you!

Breaking

If you were importing models (e.g. Page, Document, Text, SymbolMaster etc.) like so:

import Document from '@​brainly/html-sketchapp/html2asketch/document';
import SymbolMaster from '@​brainly/html-sketchapp/html2asketch/symbolMaster';

please update to:

import {Document, SymbolMaster} from '@​brainly/html-sketchapp';

That's it ✨

New

  • two new top level methods 🔥
    • nodeTreeToSketchGroup - that walks given DOM subtree recursively and creates a tree of Sketch groups and layers
    • nodeTreeToSketchPage - that wraps nodeTreeToSketchGroup and crates a page with an (optional) Artboard where all groups and layers are placed
screen shot 2018-04-19 at 23 12 42
  • Artboard object
  • index.js file that lets you import html-sketchapp in a convenient way
import {Document, Page, Text, nodeToSketchLayers} from '@​brainly/html-sketchapp';
  • TypeScript files with type definitions
  • skipSystemFonts option

some websites or component libraries use font-family lists starting with OS-specific fonts, if the option 'skipSystemFonts' is enabled, we skip those fonts to choose a font Sketch is capable of.

  • getRectangleName option that gives you full control over layer names

Improved

  • Fixed bug in the Page object where width and height were mixed up
  • ES5 transpilation for better compat
  • Electron compat improvements (BCR)


This PR has been generated by Renovate Bot.

@markdalgleish
Copy link
Member

Width and height properties have flipped in snapshot tests, but this is expected: html-sketchapp/html-sketchapp@8e4dfe4

@markdalgleish markdalgleish changed the title fix(deps): Update @brainly/html-sketchapp to 3.x fix(deps): Update html-sketchapp to v3 May 14, 2018
@markdalgleish
Copy link
Member

Note that, as of v3, the Sketch plugin is no longer published to npm. As a result, the install command now downloads the release from GitHub, which is the officially documented source for the plugin going forwards.

@renovate renovate bot changed the title fix(deps): Update html-sketchapp to v3 fix(deps): Update @brainly/html-sketchapp to 3.x May 14, 2018
@renovate
Copy link
Contributor Author

renovate bot commented May 14, 2018

PR has been edited

As this PR has been edited, Renovate will stop updating it in order to not cause any conflicts or other problems. If you wish to abandon your edits and have Renovate recreate this PR then you should rename this PR and then close it.

@markdalgleish markdalgleish merged commit 4d9547c into master May 14, 2018
@renovate renovate bot deleted the renovate--brainly-html-sketchapp-3.x branch May 14, 2018 04:31
@markdalgleish markdalgleish changed the title fix(deps): Update @brainly/html-sketchapp to 3.x fix(deps): Update html-sketchapp to v3.x May 14, 2018
@seek-oss-ci
Copy link

🎉 This PR is included in version 0.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

ryanseddon added a commit to ryanseddon/html-sketchapp-cli that referenced this pull request May 14, 2018
* upstream/master:
  fix(deps): Update html-sketchapp to v3.x (seek-oss#38)

# Conflicts:
#	package.json
#	script/generateAlmostSketch.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants