Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

fix(install): Update install command to use new release URL format #53

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Jun 25, 2018

As of v3.2.0, html-sketchapp has a new release URL format which breaks our install command. This PR updates the logic for generating the download URL, and also updates the minimum supported version to v3.2.0 in our package.json.

(Ping @kdzwinel)

Update: Also had to update the snapshots to match the latest version of html-sketchapp.

@markdalgleish markdalgleish force-pushed the update-install-command branch from 54f77c0 to d5eea7f Compare June 25, 2018 01:40
@kdzwinel
Copy link

Ouch, sorry for that. Didn't realize someone depends on the file name. I'll be writing down release process instructions this week (@burakukula will be publishing next release), so I'll make sure that "name plugin file correctly" is on the list.

@markdalgleish
Copy link
Member Author

@kdzwinel Would it be too much trouble to start publishing the compiled Sketch plugin to npm again? That was by far the easiest from the perspective of this tool, since it didn't require an extra download step from GitHub.

Alternatively, is there a better way for us to provide a painless install process?

@markdalgleish markdalgleish merged commit fe80e6a into master Jun 28, 2018
@markdalgleish markdalgleish deleted the update-install-command branch June 28, 2018 01:42
@kdzwinel
Copy link

@markdalgleish I didn't want to keep build artifacts in the repo or artificially inflate NPM package size, but if it makes it much easier for you we can start including it again when deploying to NPM.

@markdalgleish
Copy link
Member Author

Yeah, I don't want to force you to bloat up your npm package. I guess the main thing is that the plugin release process is automated so that we can depend on it to be consistent across releases. Is this the case already?

@kdzwinel
Copy link

Not really automated (can we automate creation of a GH release?), but it's on the release checklist, so you can be fairly sure we will remember about it. I'm starting to think though that it might be a good idea to put it back on npm - html-sketchapp/html-sketchapp#121

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants