Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixpanel Integration Group Properties can't be overwritten due to .set_once() call #686

Open
rpatel05 opened this issue Jul 1, 2022 · 0 comments

Comments

@rpatel05
Copy link

rpatel05 commented Jul 1, 2022

if (traits && Object.keys(traits).length) {
for (var ind = 0; ind < groupIdentifierTraits.length; ind++) {
window.mixpanel
.get_group(groupIdentifierTraits[ind], groupId)
.set_once(traits);
}
}

Mixpanel integration Group properties call is passed in as set_once(traits) making it so that group props can never be overwritten if the value changes. Suggest changing it to a .set(traits) call or I know a Segment team member considered adding a toggle such as:

if (useSetInGroupCalls === true) {
        window.mixpanel
        .get_group(groupIdentifierTraits[ind], groupId)
        .set(traits);
} else {
      window.mixpanel
        .get_group(groupIdentifierTraits[ind], groupId)
        .set_once(traits);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant