Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal dialog closes when dragging and releasing mouse button outside dialog #339

Closed
bgits opened this issue Mar 17, 2015 · 7 comments
Closed

Comments

@bgits
Copy link

bgits commented Mar 17, 2015

When slider is used inside of a bootstrap modal and the user drags the mouse off the modal, under normal operation, the modal stays open, if the modal uses bootstrap-slider the modal closes.

This used be an issue in bootstrap as well, but was fixed as per below thread:

twbs/bootstrap#13816

@seiyria
Copy link
Owner

seiyria commented Mar 17, 2015

I'd need a demo, though it is more or less self-explanatory. What I don't understand is why it's an issue here if bootstrap fixes it, and presumably you're using a bootstrap modal to do display.

@bgits
Copy link
Author

bgits commented Mar 18, 2015

It seems to trigger a click event when the user drags off the modal and then releases the mouse button.

@bgits
Copy link
Author

bgits commented Mar 18, 2015

Here is a demo. Mouse is not displayed so I logged to console the events triggered.
modal_close 2

@bgits
Copy link
Author

bgits commented Mar 19, 2015

One more observation. This bug only happens in chrome

@ZeVS777
Copy link
Contributor

ZeVS777 commented Dec 13, 2016

VERSION 9.2.0
This plugin does not bubble the mousedown event to bootstrap modal, so there no check close or not to close modal.
in the
_mousedown: function _mousedown(ev) {
I change
this._pauseEvent(ev);
on
ev.returnValue = false;

@seiyria
Copy link
Owner

seiyria commented Dec 13, 2016

Please submit a pull request if your fix works. We'd appreciate it!

@rovolution
Copy link
Collaborator

fix was merged/released in v9.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants