Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Ruff for Python Code #1562

Closed
tigercosmos opened this issue Sep 1, 2024 · 8 comments
Closed

Apply Ruff for Python Code #1562

tigercosmos opened this issue Sep 1, 2024 · 8 comments

Comments

@tigercosmos
Copy link
Collaborator

tigercosmos commented Sep 1, 2024

Ruff is the fastest linter and formatter written in Rust for the Python code. Since we already introduce clang-format in the project for the C++ part, the next step is to start formatting and lintting on the Python side.

@seladb
Copy link
Owner

seladb commented Sep 1, 2024

@tigercosmos do you suggest we use it instead of Black as a formatter or just for linting?

@tigercosmos
Copy link
Collaborator Author

@seladb Ruff functions as both a formatter and a linter, and I chose it because it appears to be the fastest option. However, I'm open to discussing which tool we should use.

@tigercosmos
Copy link
Collaborator Author

@Dimi1010 @egecetin @clementperon please also share your opinions

@Dimi1010
Copy link
Collaborator

Dimi1010 commented Sep 1, 2024

I don't have a strong opinion, so I am fine with either.

@egecetin
Copy link
Collaborator

egecetin commented Sep 2, 2024

I'm also fine with all options since the python code base is just for testing and really short in terms of line

@seladb
Copy link
Owner

seladb commented Sep 3, 2024

I'm also okay with using it for both. It's a lot faster than Black / Pylint but we'll probably not notice it because our Python code base is very small

@tigercosmos
Copy link
Collaborator Author

Okay, all of us are fine with either tool. I will try to use Ruff first. :)

@seladb
Copy link
Owner

seladb commented Sep 26, 2024

@tigercosmos can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants