Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Header-widget by features #8

Open
3 tasks
azinit opened this issue Nov 8, 2021 · 1 comment
Open
3 tasks

Split Header-widget by features #8

azinit opened this issue Nov 8, 2021 · 1 comment
Labels

Comments

@azinit
Copy link
Member

azinit commented Nov 8, 2021

At the moment there are a lot of redundant logic at widget level

It should be decompose as independent slices (choose any name what you prefer):

  • features/search (SearchBar)
  • sharead/ui/brand (Logo)
  • features/navigation (NavLinks, at start I suppose we could place it into features)

You could choose any another decomposition way, but the main requirement - keep at Header only that logic, that it need

image

For any question ping me 🚀

@azinit azinit added the refactor label Nov 8, 2021
@azinit
Copy link
Member Author

azinit commented Nov 8, 2021

As a good example of header decomposition:

https://feature-sliced.design/docs/reference/layers/widgets

@azinit azinit added the good first issue Good for newcomers label Nov 8, 2021
@azinit azinit moved this to Todo in 📓 Sharead Backlog Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant