Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vietnamese translation #48

Closed
ghost opened this issue Nov 2, 2021 · 6 comments
Closed

Vietnamese translation #48

ghost opened this issue Nov 2, 2021 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Nov 2, 2021

No description provided.

@ghost ghost added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 2, 2021
@an-ngb
Copy link
Contributor

an-ngb commented Nov 5, 2021

Can you provide more information about this please?

@ghost
Copy link
Author

ghost commented Nov 5, 2021

Sure! Krux now has limited unicode support (latin and extended latin characters with diacritics), so I'm asking for help with translating its UI to the various languages that can be rendered with those characters. I think this would include Vietnamese?

To add a translation, all you need to do is create a new file in the i18n/translations directory named after the locale that corresponds to it (vi-VN.json in this case). In the file, you map the English versions of the phrases to their Vietnamese equivalents.

Does that answer your question?

@an-ngb
Copy link
Contributor

an-ngb commented Nov 5, 2021

Not sure I can translate it 100% right but I think I can help you a little bit about this issue. Can I join this project with you? 👍

@ghost
Copy link
Author

ghost commented Nov 5, 2021

Yep, just make a pull request with your changes and I'll look it over. Thanks!

@an-ngb
Copy link
Contributor

an-ngb commented Nov 6, 2021

Thanks, I'll try my best!

@ghost
Copy link
Author

ghost commented Nov 25, 2021

Resolved by #64

@ghost ghost closed this as completed Nov 25, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant