From f6bbe7727be0c64a4ad632f72bffdec789b891ad Mon Sep 17 00:00:00 2001 From: Emil Lundberg Date: Thu, 31 Aug 2023 14:12:24 +0200 Subject: [PATCH 1/5] Remove outdated spec reference anchors --- index.bs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/index.bs b/index.bs index 28eaedd3d..9d8c27978 100644 --- a/index.bs +++ b/index.bs @@ -188,12 +188,6 @@ spec: credential-management-1; urlPrefix: https://w3c.github.io/webappsec-creden text: CredentialCreationOptions; url: dictdef-credentialcreationoptions type: dictionary text: CredentialRequestOptions; url: dictdef-credentialrequestoptions - for: Credential - type: method - text: [[CollectFromCredentialStore]](origin, options, sameOriginWithAncestors) - text: [[Create]](origin, options, sameOriginWithAncestors) - text: [[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors) - text: [[Store]](credential, sameOriginWithAncestors) for: CredentialsContainer type: method text: create(); url: dom-credentialscontainer-create From a2cec5bb9676bf185d95d441b43d4b8406fb0339 Mon Sep 17 00:00:00 2001 From: Emil Lundberg Date: Thu, 31 Aug 2023 14:13:01 +0200 Subject: [PATCH 2/5] Link to our implementation of [[Store]], as described --- index.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.bs b/index.bs index 9d8c27978..808bea334 100644 --- a/index.bs +++ b/index.bs @@ -1688,7 +1688,7 @@ that are returned to the caller when a new credential is created, or a new asser {{PublicKeyCredential}}'s [=interface object=] inherits {{Credential}}'s implementation of {{Credential/[[CollectFromCredentialStore]](origin, options, sameOriginWithAncestors)}}, and defines its own implementation of {{PublicKeyCredential/[[Create]](origin, options, sameOriginWithAncestors)}}, {{PublicKeyCredential/[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)}}, and -{{Credential/[[Store]](credential, sameOriginWithAncestors)}}. +{{PublicKeyCredential/[[Store]](credential, sameOriginWithAncestors)}}. ### `CredentialCreationOptions` Dictionary Extension ### {#sctn-credentialcreationoptions-extension} From 125c495dfcb109abf35432a9c7a3c686de447ff6 Mon Sep 17 00:00:00 2001 From: Emil Lundberg Date: Thu, 31 Aug 2023 14:13:24 +0200 Subject: [PATCH 3/5] Reference Credential/[[Store]] in our implementation of it --- index.bs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/index.bs b/index.bs index 808bea334..ec6305415 100644 --- a/index.bs +++ b/index.bs @@ -2727,8 +2727,10 @@ The steps for [=issuing a credential request to an authenticator=] are as follow
-The \[[Store]](credential, sameOriginWithAncestors) method is not supported -for Web Authentication's {{PublicKeyCredential}} type, so it always throws an error. +The {{Credential/[[Store]](credential, sameOriginWithAncestors)}} method is not supported +for Web Authentication's {{PublicKeyCredential}} type, +so its implementation of the \[[Store]](credential, sameOriginWithAncestors) +[=internal method=] always throws an error. Note: This algorithm is synchronous; the {{Promise}} resolution/rejection is handled by {{CredentialsContainer/store()|navigator.credentials.store()}}. From 235ab6e3714d840e2fcc9cac65e93c78e6e83ac4 Mon Sep 17 00:00:00 2001 From: Emil Lundberg Date: Thu, 31 Aug 2023 14:26:45 +0200 Subject: [PATCH 4/5] Pluralize implementations --- index.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.bs b/index.bs index ec6305415..d8e116e81 100644 --- a/index.bs +++ b/index.bs @@ -1687,7 +1687,7 @@ that are returned to the caller when a new credential is created, or a new asser {{PublicKeyCredential}}'s [=interface object=] inherits {{Credential}}'s implementation of {{Credential/[[CollectFromCredentialStore]](origin, options, sameOriginWithAncestors)}}, and defines its own -implementation of {{PublicKeyCredential/[[Create]](origin, options, sameOriginWithAncestors)}}, {{PublicKeyCredential/[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)}}, and +implementations of {{PublicKeyCredential/[[Create]](origin, options, sameOriginWithAncestors)}}, {{PublicKeyCredential/[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)}}, and {{PublicKeyCredential/[[Store]](credential, sameOriginWithAncestors)}}. From d3325e6165f3d7cfc40507582e57138c073266b9 Mon Sep 17 00:00:00 2001 From: Emil Lundberg Date: Wed, 6 Sep 2023 15:13:07 +0200 Subject: [PATCH 5/5] Singularize "implementation of each of [methods]" --- index.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.bs b/index.bs index d8e116e81..989f7f781 100644 --- a/index.bs +++ b/index.bs @@ -1687,7 +1687,7 @@ that are returned to the caller when a new credential is created, or a new asser {{PublicKeyCredential}}'s [=interface object=] inherits {{Credential}}'s implementation of {{Credential/[[CollectFromCredentialStore]](origin, options, sameOriginWithAncestors)}}, and defines its own -implementations of {{PublicKeyCredential/[[Create]](origin, options, sameOriginWithAncestors)}}, {{PublicKeyCredential/[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)}}, and +implementation of each of {{PublicKeyCredential/[[Create]](origin, options, sameOriginWithAncestors)}}, {{PublicKeyCredential/[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)}}, and {{PublicKeyCredential/[[Store]](credential, sameOriginWithAncestors)}}.