-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: esm #247
feat: esm #247
Conversation
fyi I rebased on latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let beta begin! |
🎉 This PR is included in version 9.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
makes sense to me. the only situation i can think of that might cause us to back-track is if we determine that we aren't able to move forward with moving the core package to ESM-only. just to confirm, does the mention of the async change impact the consumption of this package? i'm mainly trying to consider the consumption in the core package and ensuring that peer dependencies communicate what they should. |
I believe the change won't affect it, since the main package - the one that calls it - is async as well, even before this BC. To my mind, it's just an implementation detail of the module. |
great! thank you for confirming :) |
BREAKING CHANGE:
@semantic-release/commit-analyzer
is now a native ES ModuleBREAKING CHANGE: When setting the
releaseRules
option to a path, the path must include the.js
extension, and the file must be an ES Module itself, exporting an array as defaultBefore:
After: