Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'draftRelease' option #379

Merged
merged 3 commits into from
May 28, 2023
Merged

Conversation

BetaHuhn
Copy link
Contributor

@BetaHuhn BetaHuhn commented Jun 6, 2021

Summary

This PR adds a new draftRelease option which, when set to true, will create a GitHub draft release instead of publishing an actual GitHub Release. The option defaults to false and will thus not impact current users.

Fixes #275

@BetaHuhn
Copy link
Contributor Author

BetaHuhn commented Jun 14, 2021

Any plans to merge/review this?

Friendly ping, @gr2m

@gr2m
Copy link
Member

gr2m commented Jun 14, 2021

Yes, as soon as we find the time to review it, I cannot tell when that will be right now, sorry

@BetaHuhn
Copy link
Contributor Author

No problem!

Copy link

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm waiting for this, can you please prioritize?

@alex-dixon
Copy link

Maybe until there's time to review it it could be published on a draft release channel? 😄

Some of us could give feedback, add fixes if needed, etc.

@jimCresswell
Copy link

This would be useful for us too. Happy to help if that's possible.

@tubbo
Copy link

tubbo commented Oct 4, 2021

This would also be useful to us. We'd like to use semantic-release as a means of releasing our Electron application, and because we need to wait for multiple parallel workflows to complete before we can mark it as released, we currently have a bit of a rube goldberg machine set up to handle use cases like multiple release channels. It would be a lot better if we could use semantic-release instead of combining multiple other tools together to get basically the same result.

I'd also be happy to help test and review code if that's needed. This is pretty much exactly like the implementation I have locally.

@MrSquaare
Copy link

I am also interested in this option. I have a case where I have several assets that need to be built on different operating systems. I can't have them available at release time and associate them with @semantic-releas/github. A draft option would allow me to proceed in several steps.

@gr2m gr2m self-assigned this May 28, 2023
@gr2m
Copy link
Member

gr2m commented May 28, 2023

Thank you all for your patience, for sharing your use cases and for your offers to help. I know it has been a long time coming. I finally got around to review it and it all looks good. I'll merge and release it shortly

@gr2m gr2m merged commit 3c42e02 into semantic-release:master May 28, 2023
@github-actions
Copy link

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 9.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating a draft release
7 participants