fix: compare only <owner>/<repo> when checking for rename

[jedwards1211]

This PR re-attempts the implementation made in #878 and reverted in #887, by staging a check in the plugin verifyConditions lifecycle using the owner/repo as opposed to the initial implementation where the context.options.repositoryUrl is compared against the fetched repo clone_url.

Related to #885

Screencast

Error Demo

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.1.mp4

Success Demo

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.2.mp4

[babblebey]

Great stuff @jedwards1211,

Do rake a look at the bit of nits and kindly resolve the conflict for now... We are looking to add some tests too... We'll look at how to go about that after this.

[jedwards1211]

@babblebey okay I made those changes and included the current repositoryUrl and git_url values in the error message.

There are unrelated formatting changes in here now that I ran lint:prettier:fix on lib/definitions/errors.js -- is your CI not enforcing the code formatting, or did the formatting settings change?

[jedwards1211]

Okay I opened this issue: #890

[babblebey]

Run npm run lint:prettier:fix

[jedwards1211]

sorry for the noise, vscode-prettier's fault

[jedwards1211]

@babblebey okay I added tests for EMISMATCHGITHUBURL. I also noticed that the repo rename check was being skipped if running in a GitHub action, and that it was making a redundant request for the repo information. I was able to move things around to eliminate the redundant request, and check for rename even if running in a GitHub action.

[jedwards1211]

Nice testing setup y'all! I like the thoroughness of the GitHub mocking, and also the fact that you aren't using Jest lol

[jedwards1211]

@babblebey anything else y'all need on this?

[babblebey]

Hey @jedwards1211 😁,

I gave this a whirl 😉, changes looks great 👍.... and thank you for sticking to this. I have also gone on and written a description for the PR.

In order to fulfil the test coverage requirement mentioned in the reverted PR #887. Please take a look at the review comment.

[babblebey]

This is great stuff right here @jedwards1211. I commend you for sticking to this yea.

I have given another whirl and added a video demo of my testing to the PR Description (reviewers like that stuff 😉).

[jedwards1211]

nice, thank you!

[babblebey]

🚀

[github-actions]

🎉 This issue has been resolved in version 10.1.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀