Skip to content

Commit

Permalink
fix: update required node and npm version (#273)
Browse files Browse the repository at this point in the history
  • Loading branch information
@roggervalf
roggervalf authored Sep 6, 2020
1 parent dd95a83 commit 493fbad
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"lodash": "^4.17.15",
"nerf-dart": "^1.0.0",
"normalize-url": "^5.0.0",
"npm": "^6.10.3",
"npm": "^6.13.0",
"rc": "^1.2.8",
"read-pkg": "^5.0.0",
"registry-auth-token": "^4.0.0",
Expand All @@ -47,7 +47,7 @@
"xo": "^0.29.0"
},
"engines": {
"node": ">=10.18"
"node": ">=10.19"
},
"files": [
"lib",
Expand Down

3 comments on commit 493fbad

@ipeshev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not fix it is a BREAKING CHANGE for the consumers.

@gr2m
Copy link
Member

@gr2m gr2m commented on 493fbad Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the alternative would have been to pin the got version in order to resole #273. At this current stage, using semantic-release with node 10.18 was not functional, and it was out of our control, hence the fix

@ipeshev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ОК, but make it as breaking change since it is breaking code that has nothing to do with got. Now it looks like - "to get rid of old nodes, since we are writing new ones"

Please sign in to comment.