Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Graph diagram max size causes clutter #992

Open
tscurtu opened this issue Jul 14, 2023 · 2 comments
Open

Dashboard Graph diagram max size causes clutter #992

tscurtu opened this issue Jul 14, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers ui UI related work

Comments

@tscurtu
Copy link
Contributor

tscurtu commented Jul 14, 2023

When we have more Run box elements than fit in the diagram's max size, they are render on top of each other:

image
@tscurtu tscurtu added bug Something isn't working ui UI related work labels Jul 14, 2023
@chance-sematic
Copy link
Member

I cannot repro this behavior on my side. I couldn't see it on either

https://chance.dev-usw2-sematic0.sematic.cloud/runs/3d330b983f1542bbad8305a99bc30b0f#panel=dag
nor
https://tudor.dev-usw2-sematic0.sematic.cloud/runs/049d3957085443b3aacf8a65b4cfccc2#panel=dag

Though I can clearly see it in your screenshot. I guess it might be because a node is moved during the graph is being produced, and the previous position of the node is memorized. If this is the case, I guess there is not much we can do, because we can't always reset the node position on every graph update after the user has touched that node, it might look like jiggering.

@chance-sematic chance-sematic self-assigned this Jul 14, 2023
@tscurtu
Copy link
Contributor Author

tscurtu commented Jul 17, 2023

I believe this is caused by a max diagram setting being imposed. This only happens on the nodes that are rendered on the right side of the diagram. At the beginning of the execution, all nodes fit in the diagram, but as they were dynamically generated and added, they became cluttered.

Reproduction command:

$ bazel run sematic/examples/testing_pipeline:__main__ -- \
      --cloud \
      --detach \
      --max-parallelism 10 \
      --inline \
      --nested \
      --no-input \
      --sleep 10 \
      --spam-logs 1000 \
      --fan-out 10 \
      --raise-retry 0.7 \
      --external-resource \
      --expand-shared-memory \
      --cache-namespace test \
      --images \
      --virtual-funcs \
      --fork-subprocess return 0 \
      --fork-subprocess exit 0 \
      --fork-subprocess exit 1 \
      --fork-subprocess signal 2 \
      --fork-subprocess signal 15

@tscurtu tscurtu added the good first issue Good for newcomers label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers ui UI related work
Projects
None yet
Development

No branches or pull requests

2 participants