Support multiple indexer-service endpoints #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasseman
suggested changes
Jan 13, 2023
madumas
requested review from
aasseman
and removed request for
tkornuta-semiotic
aasseman
suggested changes
Jan 23, 2023
There was a problem hiding this comment.
There is an issue with the history, probably due to the merging of master into this branch. That caused some things to get un-removed (such as vcrpy in the main dependencies, or line 114 in config.py).
I would suggest an interactive rebase onto master to fix the history.
In general, catching up to the target branch through rebasing is safer and cleaner than merging.
Signed-off-by: Marc-André Dumas <madumas@madumas.ca>
Signed-off-by: Marc-André Dumas <madumas@madumas.ca>
Signed-off-by: Marc-André Dumas <madumas@madumas.ca>
Signed-off-by: Marc-André Dumas <madumas@madumas.ca>
Signed-off-by: Marc-André Dumas <madumas@madumas.ca>
madumas
force-pushed
the
ellipfra-multi-service-endpoints
branch
from
f8bd644
to
f6621d6
Compare
Signed-off-by: Marc-André Dumas <madumas@madumas.ca>
|
it should be fine now |
Pull Request Test Coverage Report for Build 3997764554Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
aasseman
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #48, this allows specify more than one endpoint in
--indexer-service-metrics-endpoint.subgraph_query_countsums the metrics from the different endpoints for a given subgraph.Also removes some extra code and add tests.