Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whois checks for .org domains fail with "Parsing error" #78

Open
peterhoeg opened this issue Jun 1, 2018 · 12 comments
Open

whois checks for .org domains fail with "Parsing error" #78

peterhoeg opened this issue Jun 1, 2018 · 12 comments

Comments

@peterhoeg
Copy link

In the following example.org refers to an actual .org domain.

This check command:

check-whois-domain-expiration-multi.rb --domains example.org --warn 22 --critical 15

Fails with:

WhoisDomainExpirationCheck UNKNOWN: example.org (Parsing error)

This fails for all .org domains.

Doing a manual check using the ruby gem as follows works:

Gemfile.lock:

GEM
  remote: https://rubygems.org/
  specs:
    whois (4.0.6)
PLATFORMS
  ruby
DEPENDENCIES
  whois
BUNDLED WITH
   1.16.2

test.rb:

#!/usr/bin/env ruby

require 'bundler/setup'
require 'whois'

puts Whois::Client.new.lookup("example.org")
@peterhoeg peterhoeg changed the title whois checks for .org domains fail with ParsingError whois checks for .org domains fail with "Parsing error" Jun 1, 2018
@peterhoeg
Copy link
Author

@majormoses, any idea what might be going on here?

@peterhoeg
Copy link
Author

Anybody has any suggestions? It's rather problematic to have lost visibility across all .org domains.

@peterhoeg
Copy link
Author

The whois-parser gem is causing this. Working on a fix.

@peterhoeg
Copy link
Author

Upstream bug: weppos/whois-parser#97

@eheydrick
Copy link
Contributor

.io domains are also impacted. See weppos/whois-parser#92.

@majormoses
Copy link
Member

I wish I could say this is a new problem and when I have seen this it has been due to upstream issues with whois (before they split the parser off to be as separate gem) and whois-parser. I don't have the time right now to work on a fix but if you do and it gets accepted I am more than happy to pull in the new deps, make any required changes on our end, and cut a release.

@peterhoeg
Copy link
Author

There is a PR upstream which does solve it for .org domains. I'll shout when it gets merged.

@majormoses
Copy link
Member

Thanks for the update, I will keep an eye out.

@majormoses
Copy link
Member

Just so you know I have been checking at least every few days for a release with the fix in it. I will be very busy next week due to some family events going on so I will probably not be checking as often.

@majormoses
Copy link
Member

I will check back in a couple weeks, if they release in the meantime feel free to reach out.

@eheydrick
Copy link
Contributor

whois-parser 1.2.0 was just released with fixes for .org, .io and other domains. We should pull that in.
https://github.com/weppos/whois-parser/blob/master/CHANGELOG.md#release-120

@peterhoeg
Copy link
Author

@majormoses, any chance of a new release with the new whois-parser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants