Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

clients view: "onclick" instead of "a href" #262

Closed
winks opened this issue Feb 10, 2015 · 4 comments
Closed

clients view: "onclick" instead of "a href" #262

winks opened this issue Feb 10, 2015 · 4 comments
Milestone

Comments

@winks
Copy link

winks commented Feb 10, 2015

Despite being a minor thing, this is my #1 pet peeve with Uchiwa:

Clients on /#/clients have this HTML code:

<td class="main ng-binding">host-01.xyz.example.org</td>

and just selecting the hostname to copy it triggers visiting the client page (most probably some onclick event for the table cell.

Is there any good reason for not using <a href and behave like a normal web page?
If not, would you accept a PR doing that? Don't want to waste time going all over the code for this if it's not wanted.

@jbehrends
Copy link

I run into this issue also doing the same thing!

+1

@rmc3
Copy link
Contributor

rmc3 commented Feb 10, 2015

+1 as well

@palourde
Copy link
Contributor

@winks I'm pretty sure we could replace the ng-click directive with the ng-href one (https://docs.angularjs.org/api/ng/directive/ngHref) by doing something like ng-href="{{go(path)}}" on all views.

I would gladly accept a PR!

@palourde palourde added this to the 0.10.5 milestone Sep 14, 2015
@winks
Copy link
Author

winks commented Sep 14, 2015

\o/ Thank you. And sorry I never followed up on this :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants