Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

images not in panels #361

Closed
roobert opened this issue Jul 24, 2015 · 10 comments
Closed

images not in panels #361

roobert opened this issue Jul 24, 2015 · 10 comments
Labels
Milestone

Comments

@roobert
Copy link
Contributor

roobert commented Jul 24, 2015

As suggested in #360, images should be in their own frames, has this already been implemented?

Here is what I see:

no_panels

@palourde
Copy link
Contributor

Hi @roobert

Indeed, images should already have their own panels. Could you let me know the version of Uchiwa running and the URL for one of your images?

@roobert
Copy link
Contributor Author

roobert commented Aug 20, 2015

Hi Palourde, I'm running Uchiwa on debian wheezy, package version: 0.10.3-1

Example URL:

https://grafana.xxx.net/render/dashboard-solo/script/host.js?host=hostname&panelId=1&theme=light&force_image=.jpg

@palourde
Copy link
Contributor

palourde commented Sep 1, 2015

@roobert I'm absolutely unable to reproduce this issue. I tested with an image generated by JS and still, the image properly show up in its own panel.

Could you provide me the HTML code for one of your image?

@roobert
Copy link
Contributor Author

roobert commented Sep 1, 2015

Hi Palourde, I'm not sure if I'm doing something wrong? Here is an example of iframes not being separated out into separate panels, I can get you code for exactly the same situation but with images later (this is all I have to hand right now), if this is not enough?

uchiwa_no_frame

@palourde
Copy link
Contributor

palourde commented Sep 1, 2015

@roobert Oh I see, you are using an iframe to load your image. The support of dedicated panels for iframe is not implemented yet (#360).

Right now, an image will be loaded to its own panel only when defined like this on the check definition:

"metric disk": "https://domain.tld/image.jpg"

@roobert
Copy link
Contributor Author

roobert commented Sep 1, 2015

Hi Palourde, I had the same problem with images from grafana and graphite, I will redeploy a client config with images from grafana and show you the code.

Cheers,

@roobert
Copy link
Contributor Author

roobert commented Sep 1, 2015

How's this?

uchiwa_no_panel

@roobert
Copy link
Contributor Author

roobert commented Sep 1, 2015

This was after upgrading to 0.10.4 - It also looks like when resizing the screen to small sizes the details panel no longer floats to below the client details panel, was this intentional..?

@palourde
Copy link
Contributor

palourde commented Sep 2, 2015

@roobert Now I see the confusion; this behaviour was only applied to check attributes and not client attributes, which is now modified with the last PR.

Regarding the panels behaviour when resizing the window, yes it's intentional for now, until we have a true mobile compatible interface.

@roobert
Copy link
Contributor Author

roobert commented Sep 2, 2015

Ahh great, thanks @palourde! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants