Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

[Security]Uchiwa 0.22.2: SecureFlag missing in AuthenticationToken and XSRF-Token cookie #656

Closed
itsDaksha opened this issue Mar 17, 2017 · 2 comments · Fixed by #661
Closed
Assignees
Labels
Milestone

Comments

@itsDaksha
Copy link

Expected Behavior

From security point of view, it is required that SecureFlag must be set in all sensitive cookies.

Current Behavior

Currently, there is no SecureFlag in AuthenticationToken and XSRF-Token cookie

Possible Solution

SecureFlag can be added in HTTP response to avoid any security vulnerability.

Reference: https://www.owasp.org/index.php/SecureFlag

@palourde palourde added this to the 0.23.0 milestone Mar 17, 2017
@palourde
Copy link
Contributor

palourde commented Mar 17, 2017

Note: We should only set the Secure flag if the connection is encrypted over HTTPS. It should be relatively easy to do here.

@itsDaksha
Copy link
Author

Any possibility of getting this fix in 0.22.x?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants