Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

Provide Indication For Flapping Checks #673

Closed
Evesy opened this issue Mar 31, 2017 · 1 comment
Closed

Provide Indication For Flapping Checks #673

Evesy opened this issue Mar 31, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@Evesy
Copy link

Evesy commented Mar 31, 2017

A small change that I think could prove to be beneficial is to provide some sort of indication for a user when a check is in a flapping state (Particularly for when the event is currently in an OK state), rather than simply displaying the event with the current status

Expected Behavior

When an event is in a flapping state there is a visual indicator to inform the user of this, rather than them having to know about the behavior of flapping events in Sensu

Current Behavior

A flapping event is displayed just like any other event, with a visual icon (Green tick, red cross etc.) to tell the user the current state of the check.
Nothing currently says that an event is flapping, which can lead to confusion for people who see 'OK' checks in the events view (As typically an event would/should not exist for an OK result)

Possible Solution

  • Update the status icons to include an additional icon for a flapping check
  • If the event 'action' is flapping, display this in the check output status

Context

This initially threw me off when I saw an OK check in the events view of Uchiwa and took me a few minutes to realize that the check was flapping (After checking the API) -- Given we only make use of flap thresholds in one or two checks it was not something I had come across before.

For someone less familiar with Sensu this is likely to cause some confusion and wasted time trying to figure why such an event is displayed. Granted, this then needs the user to have some awareness of flapping, however it at least points them in the right direction.

@palourde palourde added this to the 0.25.0 milestone May 5, 2017
@palourde
Copy link
Contributor

palourde commented May 5, 2017

Hi @Evesy

I've just submitted https://github.com/sensu/uchiwa-web/pull/162, which adds an icon in the output of an event in the events view to indicate flapping events as suggested.

It will be included in the next release of Uchiwa.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants