From 234552e186a5b9ed814595ce83bc744034c93821 Mon Sep 17 00:00:00 2001 From: Kazuhiko Yamashita Date: Wed, 4 Dec 2024 21:57:43 +0900 Subject: [PATCH] feat: add configuration for noStrictOffsetReset (#1620) Introduce a new configuration option `noStrictOffsetReset` in the Snuba replacer deployment template and values file. This allows users to optionally disable strict offset reset behavior by setting `noStrictOffsetReset` to true in the `values.yaml` file. This change provides more flexibility in handling offset resets, which can be useful in certain deployment scenarios where strict offset management is not required or desired. --- charts/sentry/templates/snuba/deployment-snuba-replacer.yaml | 3 +++ charts/sentry/values.yaml | 1 + 2 files changed, 4 insertions(+) diff --git a/charts/sentry/templates/snuba/deployment-snuba-replacer.yaml b/charts/sentry/templates/snuba/deployment-snuba-replacer.yaml index 6c75e19d2..81739e2b9 100644 --- a/charts/sentry/templates/snuba/deployment-snuba-replacer.yaml +++ b/charts/sentry/templates/snuba/deployment-snuba-replacer.yaml @@ -105,6 +105,9 @@ spec: {{- if .Values.snuba.replacer.queuedMinMessages }} - "--queued-min-messages" - "{{ .Values.snuba.replacer.queuedMinMessages }}" + {{- if .Values.snuba.replacer.noStrictOffsetReset }} + - "--no-strict-offset-reset" + {{- end }} {{- end }} ports: - containerPort: {{ template "snuba.port" }} diff --git a/charts/sentry/values.yaml b/charts/sentry/values.yaml index b726b3fa2..c4db60248 100644 --- a/charts/sentry/values.yaml +++ b/charts/sentry/values.yaml @@ -1115,6 +1115,7 @@ snuba: # queuedMinMessages: "" # volumes: [] # volumeMounts: [] + # noStrictOffsetReset: false metricsConsumer: enabled: true