fix: del --max-batch-time-ms and enable maxBatchTimeMs in values #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In this pull request, changes have been made to the Snuba configuration to enhance flexibility and simplify management of the --max-batch-time-ms parameter. Previously, this parameter was hardcoded in several deployment templates, limiting the configurability for users.
Key Changes:
--max-batch-time-msparameter has been removed from all deployment templates where it was previously hardcoded.maxBatchTimeMsparameter in thevalues.yamlfile for all relevant Snuba consumers. This allows users to configure the--max-batch-time-msvalue directly through the Helm chart values, enhancing flexibility and ease of management.These changes are aimed at improving the manageability and configurability of the Snuba configuration, making it more adaptable to various deployment scenarios and user preferences.
Please review and provide feedback. Thank you!