Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/sentry ingest consumer #144

Merged
merged 9 commits into from
Aug 11, 2020
Merged

Feat/sentry ingest consumer #144

merged 9 commits into from
Aug 11, 2020

Conversation

yoan-adfinis
Copy link
Collaborator

This pull request enables relay and the ingest-consumer on the current version of Sentry. A follow up of #137 (and #130)

NB this seems to work on a fresh install but I've seen some 403 when doing an upgrade from the current version. 😕

@yoan-adfinis
feat(sentry): enable sentry ingest consumer
8732e2b 
Signed-off-by: Yoan Blanc <yoan.blanc@adfinis.com>
@yoan-adfinis
feat(sentry): add nginx
999a685 
Signed-off-by: Yoan Blanc <yoan.blanc@adfinis.com>
@yoan-adfinis
feat(sentry): add relay
50b6c47 
Signed-off-by: Yoan Blanc <yoan.blanc@adfinis.com>
@yoan-adfinis
feat(sentry): ingress or nginx
9be03b1 
Signed-off-by: Yoan Blanc <yoan.blanc@adfinis.com>
@yoan-adfinis
fix(sentry): ignore nginx config when disabled
76b9f05 
Signed-off-by: Yoan Blanc <yoan.blanc@adfinis.com>
@yoan-adfinis yoan-adfinis requested a review from Mokto August 10, 2020 15:01
@yoan-adfinis
feat(sentry): bump sentry version
d2107bb 
Signed-off-by: Yoan Blanc <yoan.blanc@adfinis.com>
@yoan-adfinis yoan-adfinis force-pushed the feat/sentry-ingest-consumer branch from 4a78f26 to d2107bb Compare August 10, 2020 15:01
@yoan-adfinis
Copy link
Collaborator Author

@Mokto this version includes the nginx for internal cluster usage I guess. I'm assuming many things are missing if this was to be used within the cluster.

@Mokto
Copy link
Contributor

Mokto commented Aug 10, 2020

Lgtm !
I would add some notes in the readme to explain why we need nginx (explaining that we should either use nginx, either the ingress).

Thanks for your work on this ;)

@Mokto
Copy link
Contributor

Mokto commented Aug 10, 2020

& change the version to 5.0.0 ;)

@yoan-adfinis
chore(sentry): explain ingress vs nginx
6dc8e8d 
Signed-off-by: Yoan Blanc <yoan.blanc@adfinis.com>
@yoan-adfinis yoan-adfinis added enhancement New feature or request and removed work in progress labels Aug 11, 2020
@Mokto
Copy link
Contributor

Mokto commented Aug 11, 2020 •
edited
Loading

@yoan-adfinis
I'm taking the liberty to add a commit to your branch. Hope that's fine?
I'm leaving for vacations tomorrow (2 weeks), so I'd like this PR to be merged today ;)

Redis connection is not working with external redis (probably it's the same for kafka, I'll try)

@yoan-adfinis
Copy link
Collaborator Author

Hope that's fine?

Absolutely.

I'm leaving for vacations tomorrow

Same same, kind of. I already wish you some great time off.

@Mokto
Copy link
Contributor

Mokto commented Aug 11, 2020

@yoan-adfinis can you check my commit ?
I think everything is working fine now :)

Enjoy your vacations too!

@Mokto Mokto merged commit 7ae3651 into develop Aug 11, 2020
@Mokto Mokto deleted the feat/sentry-ingest-consumer branch August 11, 2020 14:45
This was referenced Apr 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mokto Mokto Awaiting requested review from Mokto

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoan-adfinis @Mokto