Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce global tolerations across all components #1580

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

patsevanton
Copy link
Contributor

@patsevanton patsevanton commented Oct 26, 2024

Description

This pull request introduces a global tolerations fallback mechanism across all deployments in the Sentry Helm chart. This enhancement allows users to define tolerations at a global level, which will be applied to all deployments if specific tolerations are not explicitly defined at the deployment level.

Changes Made

  • Added a global tolerations field in the values.yaml file.
  • Updated all deployment templates to include a fallback to the global tolerations if specific tolerations are not provided.
  • Ensured that the global tolerations are applied consistently across all Kubernetes resources, including jobs, deployments, and stateful sets.

Please review the changes and provide feedback. If everything looks good, feel free to merge this pull request.
Thank you!

@patsevanton
Copy link
Contributor Author

k get pod -n test

NAME                                                              READY   STATUS    RESTARTS      AGE
sentry-billing-metrics-consumer-68c96c49f4-lcjzc                  1/1     Running   0             3m29s
sentry-clickhouse-0                                               1/1     Running   0             14m
sentry-cron-5bdc5f8dc9-bwflb                                      1/1     Running   1 (13m ago)   14m
sentry-generic-metrics-consumer-5c4d7467c8-j75q2                  1/1     Running   0             3m28s
sentry-ingest-consumer-attachments-6958c9d99d-98c8w               1/1     Running   0             3m27s
sentry-ingest-consumer-events-7dff4467b7-xjjh6                    1/1     Running   0             3m26s
sentry-ingest-consumer-transactions-697848b7f-4crlm               1/1     Running   0             3m25s
sentry-ingest-monitors-c59cc98cd-9cdpj                            1/1     Running   0             3m25s
sentry-ingest-occurrences-85f65f65b6-cnfdm                        1/1     Running   0             3m24s
sentry-ingest-replay-recordings-bc8d5b6bb-4mqxh                   1/1     Running   0             3m23s
sentry-issue-occurrence-consumer-85b545496c-l4lkh                 1/1     Running   0             3m9s
sentry-kafka-controller-0                                         1/1     Running   0             14m
sentry-kafka-controller-1                                         1/1     Running   0             14m
sentry-kafka-controller-2                                         1/1     Running   0             14m
sentry-metrics-consumer-6f6fc8fdcd-6x8n9                          1/1     Running   0             3m23s
sentry-nginx-7bb968f688-b9c2s                                     1/1     Running   0             14m
sentry-post-process-forward-errors-57487778dc-x4crb               1/1     Running   0             3m22s
sentry-post-process-forward-issue-platform-5884bb66-c2l4l         1/1     Running   0             3m21s
sentry-post-process-forward-transactions-5bf6d864d6-jp2g5         1/1     Running   0             3m20s
sentry-rabbitmq-0                                                 1/1     Running   0             14m
sentry-relay-7c66c955c4-4bxtw                                     1/1     Running   0             3m4s
sentry-sentry-postgresql-0                                        1/1     Running   0             14m
sentry-sentry-redis-master-0                                      1/1     Running   0             14m
sentry-sentry-redis-replicas-0                                    1/1     Running   0             14m
sentry-snuba-api-cb6f47f66-bkkfg                                  1/1     Running   0             14m
sentry-snuba-consumer-85c5f6b9c-z27bj                             1/1     Running   0             3m20s
sentry-snuba-generic-metrics-counters-consumer-64688445c-vthhx    1/1     Running   0             3m16s
sentry-snuba-generic-metrics-distributions-consumer-77ccf5nhkl4   1/1     Running   0             3m15s
sentry-snuba-generic-metrics-sets-consumer-6754bf8b77-l5s5x       1/1     Running   0             3m14s
sentry-snuba-group-attributes-consumer-7bf8f89c47-vrvkw           1/1     Running   0             3m13s
sentry-snuba-metrics-consumer-5bf57b5776-9dd25                    1/1     Running   0             3m13s
sentry-snuba-outcomes-billing-consumer-f96ddfcb6-cr9rp            1/1     Running   0             3m12s
sentry-snuba-outcomes-consumer-7fd9b7bfd4-vcjk5                   1/1     Running   0             3m8s
sentry-snuba-replacer-5d7d547476-nmw9n                            1/1     Running   0             3m7s
sentry-snuba-replays-consumer-7dbb575bfd-lhqlw                    1/1     Running   0             3m11s
sentry-snuba-spans-consumer-77cf4c4d87-7xhsv                      1/1     Running   0             3m10s
sentry-snuba-subscription-consumer-events-796bfffc75-vszx2        1/1     Running   0             3m6s
sentry-snuba-subscription-consumer-metrics-7d77dfdbd4-46xjh       1/1     Running   0             3m6s
sentry-snuba-subscription-consumer-transactions-556496dc6cn8gnq   1/1     Running   0             3m5s
sentry-snuba-transactions-consumer-798bcdd8bf-hsh2h               1/1     Running   0             3m9s
sentry-subscription-consumer-events-56cbbb569d-f4dhs              1/1     Running   0             3m19s
sentry-subscription-consumer-generic-metrics-6785bb66cf-k2xxx     1/1     Running   0             3m18s
sentry-subscription-consumer-metrics-7f6c774979-lzbsq             1/1     Running   0             3m17s
sentry-subscription-consumer-transactions-6fc8847cfd-2c6jn        1/1     Running   0             3m16s
sentry-web-68478c8d7f-c9ntj                                       1/1     Running   0             14m
sentry-worker-58788dd48-xh9cg                                     1/1     Running   1 (13m ago)   14m
sentry-zookeeper-clickhouse-0                                     1/1     Running   0             14m

@Mokto Mokto merged commit 7b48399 into sentry-kubernetes:develop Oct 26, 2024
2 of 3 checks passed
@Mokto Mokto mentioned this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants